Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ramble to track the origin of a FOM #229

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

rfbgo
Copy link
Collaborator

@rfbgo rfbgo commented Jul 27, 2023

This change allows ramble to check if a FOM came from an app or a mod (and later perhaps that it is in fact a derived FOM)

This is useful as it allow the user to tell if a fom came from an app or a mod during analysis, and can be decorate as such in text print

This change also allows for the merging of contexts when a modifier and application emit the same context. Previously the applications context was lost.

This change allows ramble to check if a FOM came from an app or a mod
(and later perhaps that' its infact a dervied FOM)

This is useful as it allow the user to tell if a fom came from an app or
a mod during analysis, and can be decorate as such in text print
@rfbgo rfbgo marked this pull request as draft July 27, 2023 22:03
Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It's nice how easy it was to make the merging work!

Once some testing is added, it'll probably be ready to merge. :)

lib/ramble/ramble/language/shared_language.py Show resolved Hide resolved
@rfbgo rfbgo marked this pull request as ready for review July 28, 2023 19:54
@douglasjacobsen douglasjacobsen merged commit 351d160 into GoogleCloudPlatform:develop Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants