Redirect prints from Spack to log file #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapomeroy
force-pushed
the
redirect_prints
branch
3 times, most recently
from
2da9034
to
0dadf8b
Compare
dapomeroy
force-pushed
the
redirect_prints
branch
10 times, most recently
from
1c47f12
to
46b7075
Compare
douglasjacobsen
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Thanks for this. Overall it looks good, I have a few things that should be changed in the PR, and one bug that I ran into while testing it.
It seems if you use debug mode, most of the debug output is just lost entirely and not written to any of the log files.
Verbose appears to work correctly, but debug doesn't for some reason.
lib/ramble/ramble/test/end_to_end/unused_compilers_are_skipped.py
Outdated
Show resolved
Hide resolved
lib/ramble/ramble/test/modifier_functionality/mock_spack_modifier.py
Outdated
Show resolved
Hide resolved
dapomeroy
force-pushed
the
redirect_prints
branch
from
46b7075
to
d9af42b
Compare
|
All fixed up. Just needed to pass the global debug setting to the logger. |
douglasjacobsen
requested changes
Sep 15, 2023
Redirects prints from Spack to a log file to provide a better experience to users
dapomeroy
force-pushed
the
redirect_prints
branch
from
d9af42b
to
4d70617
Compare
douglasjacobsen
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirects prints from Spack to a log file to provide a cleaner command line experience for users. Logger wraps everything within the run_pipeline() method in workspace.py, which currently covers workspace setup, analyze, and mirror commands. All of stdout gets redirected into the logfile, unless inside a logger.force_echo() block. Added force_echo() blocks to all errors / tty.die within spack.py to ensure errors get printed to stdout.