Allow empty spack environments when constructing hash #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfbgo
previously approved these changes
Dec 6, 2023
When building an experiment / workspace inventory, previously it was required that if an environment had a spack.yaml, it also created a spack.lock (or Ramble would error). This commit allows spack.yaml files that have no packages (And thus, won't concretized into a spack.lock) without throwing an error.
douglasjacobsen
force-pushed
the
fix_empty_spack_errors
branch
from
3bda3f2 to
8d1c093
Compare
rfbgo
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an experiment / workspace inventory, previously it was required that if an environment had a spack.yaml, it also created a spack.lock (or Ramble would error).
This merge allows spack.yaml files that have no packages (And thus, won't concretized into a spack.lock) without throwing an error.