Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workload and experiment tagging #387

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

douglasjacobsen
Copy link
Collaborator

This merge adds the ability for workloads (defined in either an application.py or in workspace configuration files) and experiments (via only workspace configuration files) to define their own tags.

Tags are used for two things:

  1. Several workspace and pipeline commands can be filtered on tags (such as workspace info and on).
  2. Tags are pushed into the results file

Testing and documentation is added for this feature as well.

@douglasjacobsen douglasjacobsen added documentation Improvements or additions to documentation testing Modifications to testing labels Jan 25, 2024
@douglasjacobsen douglasjacobsen requested a review from rfbgo January 25, 2024 17:51
@douglasjacobsen douglasjacobsen force-pushed the experiment_tags branch 8 times, most recently from d9d22ed to 33bc2ec Compare January 25, 2024 22:20
This commit adds the ability for workload directives to define tags,
which are then tracked in experiment instances.

Additionally, a `tags` attribute is added to the YAML schema for
experiments and workloads. This allows experiments to be tagged at a
finter grain within a workspace.

The workspace info command is also updated to provide more control over
the information provided.
This command allows other pipline commands (such a `on` and
`workspace setup`) to fitler the experiments they act on based on their
tags.
@douglasjacobsen douglasjacobsen force-pushed the experiment_tags branch 2 times, most recently from 1ef9ec1 to e26491f Compare January 26, 2024 04:21
@douglasjacobsen douglasjacobsen marked this pull request as ready for review January 26, 2024 04:22
Copy link
Collaborator

@rfbgo rfbgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple request, otherwise LGTM

I think in general this feature makes more sense to me when looking across workspaces (which isn't in yet), but that can always be added later

lib/ramble/ramble/application.py Show resolved Hide resolved
@rfbgo rfbgo merged commit 38f92af into GoogleCloudPlatform:develop Feb 1, 2024
5 checks passed
@douglasjacobsen douglasjacobsen deleted the experiment_tags branch March 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Modifications to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants