Add filtering so warning is only given for non-default-selection #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
I think this is good. One alternative (I don't really have a strong preference) would be to make whether the pipeline uses phases an attribute of each individual pipeline, and then guard the warning by that.
That would also help catch an (arguably very weird) edge case where an application purposefully removes all of its phases but the phase filter is still ["*"].
Previously this would also work for pipelines that don't have phases (eg ramble on). This adds a simple check to only warn if the user requested a change to the phases away from the default path
douglasjacobsen
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would also work for pipelines that don't have phases (eg ramble on). This adds a simple check to only warn if the user requested a change to the phases away from the default path