Clean up use of mutable defaults under lib/ramble/ramble #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danger of mutable defaults: https://pylint.pycqa.org/en/latest/user_guide/messages/warning/dangerous-default-value.html. The cleanup list comes from: ``` pylint --disable=all --enable=W0102 lib/ramble/ramble/* ``` There's also a flake8 plugin (bug-bear) that provides this check (along with other more opinionated checks.) Can be a follow-up to see if we should incorporate this into the CI checks.
douglasjacobsen
approved these changes
Jan 21, 2025
douglasjacobsen
merged commit f02c5d8
into
GoogleCloudPlatform:develop
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danger of mutable defaults:
https://pylint.pycqa.org/en/latest/user_guide/messages/warning/dangerous-default-value.html.
The cleanup list comes from:
There's also a flake8 plugin (bug-bear) that provides this check (along with other more opinionated checks.) Can be a follow-up to see if we should incorporate this into the CI checks.