Clean up NVIDIA HPC Benchmark application definitions #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the execution path for NVIDIA container workloads, to make sure they execute binaries from `/workspace`. Additionally, the internal_mpi_command variable is added to all of these to make execution using the builtin MPI easier (rather than strictly external MPI).
douglasjacobsen
added
the
application definition
linsword13
reviewed
Jan 21, 2025
var/ramble/repos/builtin/base_applications/nvidia-hpc-benchmarks/base_application.py
Outdated
Show resolved
Hide resolved
douglasjacobsen
force-pushed
the
nvidia-container-fixes
branch
from
8b370c8 to
ad384a0
Compare
This commit extract common logic from the NVIDIA containerized benchmark application definitions into a base application. This base application is then used to apply the same logic to each of the NVIDIA HPC Benchmark implementations.
douglasjacobsen
force-pushed
the
nvidia-container-fixes
branch
from
ad384a0 to
c504b43
Compare
linsword13
approved these changes
Jan 22, 2025
douglasjacobsen
merged commit eba471a
into
GoogleCloudPlatform:develop
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large portion of the logic to allow exectuion of the NVIDIA HPC Benchmarks using the NVIDIA HPC Benchmark container is common regardless of which benchmark is being executed.
This merge extracts this logic into a common base_application definition, and applies it to the application definitions for each benchmark.