Fix for lab GSP1078 (Cloud Run Canary Deployments) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud Run Progression
* multiple lab updates
…CD via ACM or Clouddeploy (GoogleCloudPlatform#14) Incorporate Cloud Deploy
* Migrating images into repo
GoogleCloudPlatform#17) * Incorporating cloud deploy
* Kustomize lab
* Cloud Code lab
* app onboarding lab
Co-authored-by: gushob <[email protected]>
* Initial commit * Add Apache license header
* Cloud Run tutorial
Env var for app name
* formatting updates
…oogleCloudPlatform#41) * change cluster name from canary to staging and fixing repo link
* Updating lab for Github
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing files *.json-tmpl (which were, I suppose, deleted by mistake several commits ago) which is necessary for Lab being passed successfully.
Tested within the mentioned lab, and finished it successfully (Got my badge. Thanks Google)
File main-cloudbuilder.yaml seems to be excessive, as the lab instructions are pointed for master branch (not main), but, it causing no harm and just exists.