feat(example): Add Generative AI example using RAG and Vector Search #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
suggested changes
Jun 6, 2024
Comment on lines
22
to
35
| output "host_vpc_project_id" { | ||
| description = "This is the Project ID where the Host VPC network is located" | ||
| value = var.vector_search_vpc_project | ||
| } | ||
|
|
||
| output "host_vpc_network" { | ||
| description = "This is the Self-link of the Host VPC network" | ||
| value = var.network | ||
| } | ||
|
|
||
| output "notebook_project_id" { | ||
| description = "The Project ID where the notebook will be run on" | ||
| value = var.machine_learning_project | ||
| } |
There was a problem hiding this comment.
why are the inputs been added as outputs?
There was a problem hiding this comment.
Ideally I'd use values from google_workbench_instance.instance, but since it is unstable, this is a way I found to still be able to run terraform output commands without having any issues.
There was a problem hiding this comment.
we could put the values using google_workbench_instance.instance on this PR, but when people are not able to use the resource they will have some trouble following the readme steps
examples/genai-rag-multimodal/multimodal_rag_langchain_infra.tf
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example uses: