Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 5-app-infra-step #48

Merged
merged 45 commits into from
Jun 13, 2024
Merged

Refactor 5-app-infra-step #48

merged 45 commits into from
Jun 13, 2024

Conversation

mariammartins
Copy link
Contributor

Hey folks, this PR contains:

  • 5-app-infra refactoring step
  • Update of steps to deploy 5-app-infra locally
  • Changing step 6-machine-learning to "vertex-ai-machine-learning-pipeline" as an example

mariammartins and others added 30 commits May 28, 2024 16:57
@mariammartins
Initial commit
c7bcb75
@mariammartins
moving gcp-policies step to root README
d905604
@mariammartins
refactoring the publish-artifacts and service-catalog steps to the ro…
40858fc 
…ot README
@mariammartins
refactoring the artifact publish and service catalog repos steps
96cefb2
@mariammartins
changing step 5-vps-sc to root README
b98a353
@mariammartins
refactoring assets
96ba44a
@mariammartins
updata service catalog module name
c89498e
@mariammartins
add VPC-SC on root README
3c22218
@mariammartins
add VPC-SC bash commands
5c9f265
@mariammartins
update VPC-SC bash commands
5fe0dd5
@mariammartins
changing step 7-ml-post-deployment to 6-ml README
061f4f5
@mariammartins
refactoring modules and source repos
500cbb5
@mariammartins
fix 6-machine-learning step after app-infra refactoring
c8d2677
@mariammartins
update 6-machine-learning step README
8831dbe
@mariammartins
update README
b7443b4
@mariammartins
update README
a39cce2
@mariammartins @caetano-colin
Update 5-app-infra/README.md
3846992 
Co-authored-by: Caetano Colin <[email protected]>
@mariammartins
update README
315e42b
@mariammartins
remove VPC-SC step
51fe4f9
@mariammartins
insertion of the VPC-SC step as a prerequisite for the example
b5a0c69
@mariammartins
merge of 6-machine-learning-steps and 6-mal-pipeline steps
adde6ac
@mariammartins @caetano-colin
Update 5-app-infra/README.md
63a2c91 
Co-authored-by: Caetano Colin <[email protected]>
@mariammartins @caetano-colin
Update 5-app-infra/README.md
14c769f 
Co-authored-by: Caetano Colin <[email protected]>
@mariammartins @caetano-colin
Update 5-app-infra/README.md
7d2565f 
Co-authored-by: Caetano Colin <[email protected]>
@mariammartins
update 6-machine-learning README
c7d7b9a
@mariammartins
update README
23fd95e
@mariammartins
update README
31332ab
@mariammartins
update 6-machine-learning step
f3acad0
@mariammartins
Merge branch 'refactor/app-infra-step' of https://github.com/mariamma…
2411c89 
…rtins/terraform-google-enterprise-genai into refactor/app-infra-step
@mariammartins
update title
2662b47
caetano-colin
caetano-colin suggested changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@caetano-colin caetano-colin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style changes

examples/vertex-ai-machine-learning-pipeline/README.md Outdated Show resolved Hide resolved
examples/vertex-ai-machine-learning-pipeline/README.md Outdated Show resolved Hide resolved
examples/vertex-ai-machine-learning-pipeline/README.md Outdated Show resolved Hide resolved
examples/vertex-ai-machine-learning-pipeline/README.md Outdated Show resolved Hide resolved
examples/vertex-ai-machine-learning-pipeline/README.md Outdated Show resolved Hide resolved
examples/vertex-ai-machine-learning-pipeline/README.md Outdated Show resolved Hide resolved
@caetano-colin
Copy link
Contributor

caetano-colin commented Jun 11, 2024 •
edited
Loading

Some things to be done before merge:

  • Adjust main README.md on section 6. ml-pipeline. Remove the section and add on readme a section about the examples, and link the example there.

@sleighton2022
Copy link
Collaborator

Linting fails

caetano-colin
caetano-colin reviewed Jun 12, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mariammartins
Copy link
Contributor Author

Linting fails

Fixed

@mariammartins mariammartins changed the title Refactor/5-app-infra-step Refactor 5-app-infra-step Jun 13, 2024
@mariammartins mariammartins marked this pull request as draft June 13, 2024 15:15
@mariammartins mariammartins marked this pull request as draft June 13, 2024 15:15
@mariammartins mariammartins marked this pull request as ready for review June 13, 2024 15:27
@sleighton2022 sleighton2022 merged commit 3a2e40a into GoogleCloudPlatform:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renato-rudnicki renato-rudnicki renato-rudnicki left review comments

@caetano-colin caetano-colin caetano-colin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariammartins @caetano-colin @sleighton2022 @renato-rudnicki