Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mock registry if MOCK_GOOGLE_TOKEN is true #156

Merged
merged 2 commits into from
Oct 10, 2024
+8 −2
Merged

Use mock registry if MOCK_GOOGLE_TOKEN is true #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d74b2
use mock registry if MOCK_GOOGLE_TOKEN is true
spowelljr Oct 4, 2024
cdea91b
add comment on why we're mocking the registry
spowelljr Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,25 @@ func createPullSecret(clientset *kubernetes.Clientset, ns *corev1.Namespace, cre
}
}

// The MOCK_GOOGLE_TOKEN env var prevents using credentials to fetch the token. Instead the token will be mocked.
registries := append(gcr_config.DefaultGCRRegistries[:], gcr_config.DefaultARRegistries[:]...)

// The MOCK_GOOGLE_TOKEN env var prevents using credentials to fetch the
// token. Instead the token will be mocked. It also sets a mock registry
// due to pulls to Artifact Registry for publicly available images with
// mock credentials causing unauthorized errors. See:
// https://github.com/kubernetes/minikube/issues/19714
mockToken, _ := strconv.ParseBool(os.Getenv("MOCK_GOOGLE_TOKEN"))
var token *oauth2.Token
if mockToken {
spowelljr marked this conversation as resolved.
Show resolved Hide resolved
token = &oauth2.Token{AccessToken: "mock_access_token"}
registries = []string{"mock-registry"}
} else {
token, err = creds.TokenSource.Token()
if err != nil {
return err
}
}
var dockercfg string
registries := append(gcr_config.DefaultGCRRegistries[:], gcr_config.DefaultARRegistries[:]...)
for _, reg := range registries {
dockercfg += fmt.Sprintf(`"https://%s":{"username":"oauth2accesstoken","password":"%s","email":"none"},`, reg, token.AccessToken)
}
Expand Down