-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consider exclueded file in COPY --from cache keys #2615 #2620
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
84fee74
to
ce24f5d
Compare
Thanks for the PR here @massimeddu-sonicjobs! Seems currently there is an error when linting the go code:
|
Hi @massimeddu-sonicjobs thank you for creating this PR. |
@aaron-prindle Do you support the general flow of this PR? If not, I'd keen to know before I take a stab at driving this home. |
Hi @edwardsmit , unfortunately I cannot further work on this in the near future. Feel free to review and improve this PR if you want. |
I'm wondering if there's anyone currently working on this PR? I have experienced issues with multistage build cache that might be related. |
I'm currently not. So feel free to pick it up as @massimeddu-sj isn't working on this either. |
Why is this still being ignored? It's a bug that impacts multi-stage builds still. |
I had intended on working on this but I'm not a golang developer and it would take some personal time to learn. If time is money, then I'm broke. Kaniko is an open-source project, developers volunteer time their time to write and fix code (typically no one pays for this). |
Fixes #2615
Description
This PR consider excluded files when kaniko calculates the cache key for
COPY --from
command.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.