Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement home #10

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat: implement home #10

merged 2 commits into from
Dec 7, 2023

Conversation

thesayyn
Copy link
Collaborator

No description provided.

loosebazooka
loosebazooka reviewed Nov 22, 2023
View reviewed changes
distroless/private/tar.bzl Show resolved Hide resolved
distroless/private/home.bzl Outdated Show resolved Hide resolved
examples/home/BUILD.bazel Outdated Show resolved Hide resolved
@thesayyn
Copy link
Collaborator Author

thesayyn commented Dec 6, 2023

@loosebazooka PTAL again.

loosebazooka
loosebazooka reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR still has the 167256000 timestamp, change here or in a followup?

Also will home be auto integrated into passwd entry files? for users? Or is this something that needs to be created in addition to defining users and groups?

@thesayyn
Copy link
Collaborator Author

thesayyn commented Dec 7, 2023

I think this PR still has the 167256000 timestamp, change here or in a followup?

Also will home be auto integrated into passwd entry files? for users? Or is this something that needs to be created in addition to defining users and groups?

That’ll change in a follow up. Home will be used with passwd and flatten in a single tar for performance.

@thesayyn thesayyn merged commit 3b7a3de into main Dec 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @loosebazooka