feat: implement java_keystore #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
java_keystore
branch
from
106ac67
to
406c496
Compare
thesayyn
force-pushed
the
java_keystore
branch
from
406c496
to
af39150
Compare
|
Does this now become an environment specific build? I'm not sure I understand enough, but keytool is obtained from the build env? |
No, we depend on an hermetic jdk toolchain to get the |
|
Kk, lgtm after test fix. |
|
eh, tests are failing because of timezone differences between my local machine and the CI. so interesting to find a new way of non-hermeticity. |
thesayyn
force-pushed
the
java_keystore
branch
4 times, most recently
from
3662841
to
fa71658
Compare
thesayyn
force-pushed
the
java_keystore
branch
from
fa71658
to
a74d1fb
Compare
alexeagle
approved these changes
Nov 30, 2023
thesayyn
force-pushed
the
java_keystore
branch
11 times, most recently
from
47732b2
to
bfa6e2b
Compare
thesayyn
force-pushed
the
java_keystore
branch
from
bfa6e2b
to
5594c82
Compare
thesayyn
force-pushed
the
java_keystore
branch
5 times, most recently
from
5da9be9
to
f3b0139
Compare
|
@loosebazooka PTAL. |
thesayyn
force-pushed
the
java_keystore
branch
from
f3b0139
to
6478e25
Compare
loosebazooka
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somehow a port of jksutil into Java with parts taken from https://github.com/openjdk/jdk17u-dev/blob/a028120220f6fd28e39fe0f6190eb1f5da6a788d/make/jdk/src/classes/build/tools/generatecacerts/GenerateCacerts.java.
Using java and java_binary is less tedious than using go and go_binary since java comes bundled with java, therefore, there's no need to take dependency just for this.