Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid using the depreciated background #746

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

AmanRajSinghMourya
Copy link
Contributor

No description provided.

@monkeyWie
Copy link
Member

Thanks for you PR, but why change the colorScheme?

@AmanRajSinghMourya
Copy link
Contributor Author

To avoid using the depreciated background and used surface

@monkeyWie monkeyWie added the enhancement New feature or request label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.36%. Comparing base (56b85e5) to head (a44a4e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   61.50%   61.36%   -0.14%     
==========================================
  Files          35       35              
  Lines        3611     3611              
==========================================
- Hits         2221     2216       -5     
- Misses       1115     1123       +8     
+ Partials      275      272       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie merged commit bdda550 into GopeedLab:main Sep 18, 2024
2 of 4 checks passed
@monkeyWie
Copy link
Member

Oh I got it, thks

@AmanRajSinghMourya AmanRajSinghMourya deleted the dart_analysis_fixes branch September 18, 2024 06:52
@monkeyWie monkeyWie changed the title [ui][flutter] made dart analyser happy feat: avoid using the depreciated background Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants