Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/lab issues #299

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Bugfix/lab issues #299

merged 2 commits into from
Jan 27, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Jan 27, 2024

To test

  1. Open Lab and walk to Bloodwyn
  2. If Dialog triggers, then we're fine

Before the fix:

  • Lab crashed after 2nd frame.

@JaXt0r JaXt0r added the quick Just a small improvement, but still worth the time. ;-) label Jan 27, 2024
JucanAndreiDaniel
JucanAndreiDaniel approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@JucanAndreiDaniel JucanAndreiDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No crashes, LGTM

@JaXt0r JaXt0r merged commit 9891e04 into main Jan 27, 2024
2 checks passed
@JaXt0r JaXt0r deleted the bugfix/lab-issues branch January 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JucanAndreiDaniel JucanAndreiDaniel JucanAndreiDaniel approved these changes

Assignees
No one assigned
Labels
quick Just a small improvement, but still worth the time. ;-)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaXt0r @JucanAndreiDaniel