Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/loading errors #331

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Bugfix/loading errors #331

merged 6 commits into from
Apr 1, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Mar 29, 2024 •
edited
Loading

To test

  1. Chest in Diego's house is rotated right.
  2. There are only 4 errors in log about "unknown Gothic version for world. Assuming G1" (Before that: ~140)
  3. No log error about Culling

@JaXt0r JaXt0r mentioned this pull request Mar 29, 2024
Closed
@JaXt0r JaXt0r linked an issue Mar 29, 2024 that may be closed by this pull request
Chests are rotated wrongly #324
Closed
@JaXt0r JaXt0r marked this pull request as ready for review March 29, 2024 23:08
JucanAndreiDaniel
JucanAndreiDaniel requested changes Apr 1, 2024
View reviewed changes
Assets/GothicVR/Scripts/Creator/VobCreator.cs Outdated
var vobTree = new ZenKit.World(GameData.Vfs, vob.VobTree);
if (!vobTreeCache.TryGetValue(vob.VobTree.ToLower(), out IWorld vobTree))
{
vobTree = new ZenKit.World(GameData.Vfs, vob.VobTree).Cache();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vobTree = new ZenKit.World(GameData.Vfs, vob.VobTree).Cache();
vobTree = new ZenKit.World(GameData.Vfs, vob.VobTree);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this cache. At least the .zen itself isn't re-parsed every time.

@JaXt0r
Copy link
Contributor Author

JaXt0r commented Apr 1, 2024

I'll also add, that we leverage latest ZenKit version which also solves the last error message.

@JaXt0r JaXt0r requested review from JucanAndreiDaniel and removed request for piotrb92 April 1, 2024 16:00
@JaXt0r
Copy link
Contributor Author

JaXt0r commented Apr 1, 2024

@JucanAndreiDaniel please test again. Unfortunately I couldn't see your fire again. But the errors are gone.
Please also check if the caching still makes sense. I think so, but 🤷

JucanAndreiDaniel
JucanAndreiDaniel approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@JucanAndreiDaniel JucanAndreiDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to restart unity as it might not let you see all the lights, i see no issue on my side

@JaXt0r JaXt0r merged commit 457c983 into main Apr 1, 2024
@JaXt0r JaXt0r deleted the bugfix/loading-errors branch April 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JucanAndreiDaniel JucanAndreiDaniel JucanAndreiDaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chests are rotated wrongly
2 participants
@JaXt0r @JucanAndreiDaniel