Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/sword in hand #342

Merged
merged 5 commits into from
Apr 20, 2024
Merged

Bugfix/sword in hand #342

merged 5 commits into from
Apr 20, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Apr 16, 2024

To test

  1. Spawn Buddler (554) and Guard (204)
  2. Check if Buddler eats apple, cheese, bread, and it is in his hands
  3. Check if Guard is doing his sword animation with the weapon in his hands

Hints:

  • If you look very very closely, you will see, that the item holding position is a few millimeters off. I checked it with G1. This is normal behaviour.
  • Sometimes the world mesh doesn't load fully and NPCs fall down. I created a separate issue for that. Just restart the game if it's happening.

image

@JaXt0r
Copy link
Contributor Author

JaXt0r commented Apr 16, 2024

There's a bug remaining. Please wait with review until fixed.
image
Buddler (535) and Buddler (554)

@JaXt0r JaXt0r marked this pull request as draft April 16, 2024 16:28
@JaXt0r JaXt0r marked this pull request as ready for review April 17, 2024 03:03
Copy link
Contributor

@Romeeey Romeeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from my side.
The NPCs from the testplan are ok.

I found 2 bugs while testing, but they don't keep us from merging.
Bug tickets #346 #345 are related and should be solved close to the PR.

@JaXt0r JaXt0r merged commit 6dac5bc into main Apr 20, 2024
@JaXt0r JaXt0r deleted the bugfix/sword-in-hand branch April 20, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants