Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics disable while interactions + UseMob fix for Gomez and Cooks + Walk fixes #347

Merged
merged 7 commits into from
Apr 28, 2024
Merged

Physics disable while interactions + UseMob fix for Gomez and Cooks + Walk fixes #347

merged 7 commits into from
Apr 28, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Apr 23, 2024 •
edited
Loading

To test

  1. Boot game with the following NPCs:
  2. Buddler (527) - The one on the water. He should wash himself and shouldn't stutter (aka physics are disabled during washing)
  3. Buddler (502) - He should use cauldron again to cook.
  4. Gomez (100) - He will now directly sit on the throne without walking away first.
  5. Guard (214) - He should guard now. (Was walking into the wall before.

@JaXt0r JaXt0r marked this pull request as ready for review April 23, 2024 04:51
@JaXt0r JaXt0r requested review from Romeeey and Tyroonis April 23, 2024 04:51
@JaXt0r JaXt0r changed the title Feature/more animations Physics disable while interactions + UseMob fix for Gomez and Cooks Apr 23, 2024
@JaXt0r JaXt0r changed the title Physics disable while interactions + UseMob fix for Gomez and Cooks Physics disable while interactions + UseMob fix for Gomez and Cooks + Walk fixes Apr 24, 2024
@JaXt0r JaXt0r requested a review from BoroBongo April 27, 2024 23:16
BoroBongo
BoroBongo approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@BoroBongo BoroBongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM :D

@JaXt0r JaXt0r merged commit 3065a34 into main Apr 28, 2024
@JaXt0r JaXt0r deleted the feature/more-animations branch April 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoroBongo BoroBongo BoroBongo approved these changes

@Romeeey Romeeey Awaiting requested review from Romeeey

@Tyroonis Tyroonis Awaiting requested review from Tyroonis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaXt0r @BoroBongo