fix(GothicSky.mat): Changes during Editor.OnValidate() removed as the… #349
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y will be set at game startup without saving to .mat file directly.
…We set it now at runtime when Worlds are loaded. + Cloning the material to ensure changes aren't reflected in the actual .mat file.
ThomasMountainborn
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Downside of removing OnValidate is that changing light colors in the inspector only takes place when the in-game clock moves forward, i.e. not when paused and not when loading the world in the editor. But that's not necessarily a big problem. We want the light color values to be driven by the sky manager anyway. So it's fine by me.
…ges as we cloned the Gothic sky material already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y will be set at game startup without saving to .mat file directly.
Two major changes:
SetShaderProperties()as this alters values inside GothicSky.mat before the game starts but should only reflect runtime changes. TheSetShaderProperties()is also called during game startup which is:WorldCreator.CreateAsync() -> InitSky() -> Interpolate() -> InterpolateSky() -> SetShaderProperties()after world is loaded and before loading screne is gone.Tests showed the sky is fine at startup.