Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/lab errors #351

Merged
merged 11 commits into from
Apr 28, 2024
Merged

Bugfix/lab errors #351

merged 11 commits into from
Apr 28, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Apr 28, 2024

To test

  1. Start Lab scene
  2. Walk into Bloodwyn
  3. You shouldn't see any error on the log and his dialog should proceed until the dialog popup opens
    (Before that the dialog stopped after hero said something)

JaXt0r added 10 commits April 21, 2024 05:47
@JaXt0r
fix(NpcGetDistToWp): Null check inverted for NpcGo. Now a guard is no…
9c996cc 
…t trying to walk to a WP where it is already onto.
@JaXt0r
add(NextAnimation): Whenever an animation is finished, the nextAnimat…
bf20156 
…ion is now automatically played until overwritten.
@JaXt0r
fix(Physics): NPC animations are now correctly using physics (for wal…
e3b9548 
…king) and no physics for all the other animations.
@JaXt0r
change(AnimationPhysics): Can be overwritten by each animation type i…
0593f26 
…f needed.
@JaXt0r
fix(UseMob): When NPC is close to Mob during spawn time, it will auto…
953f11c 
…matically start transition.
@JaXt0r
fix(GoToFpStartup): Check if NPC is already on the spot at startup.
4a5481c
@JaXt0r
Merge branch 'main' into feature/more-animations
10beaa4
@JaXt0r
fix(Scrollroll.wav): Fixed exception while loading it for Lab. Nulled…
38dcaf5 
… as we don't need it here.
@JaXt0r
fix(LabBootstrapper): Hero is now cached.
e0e1aee
@JaXt0r
fix(HeadMorph): StopViseme is now called only if an NPC talked before…
d437e58 
…, not the hero.
@JaXt0r JaXt0r added the quick Just a small improvement, but still worth the time. ;-) label Apr 28, 2024
@JaXt0r JaXt0r requested a review from BoroBongo April 28, 2024 01:32
BoroBongo
BoroBongo approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@BoroBongo BoroBongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 😎

@JaXt0r JaXt0r merged commit ddb8994 into main Apr 28, 2024
@JaXt0r JaXt0r deleted the bugfix/lab-errors branch April 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoroBongo BoroBongo BoroBongo approved these changes

Assignees
No one assigned
Labels
quick Just a small improvement, but still worth the time. ;-)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaXt0r @BoroBongo