Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPC breathing and blinking #356

Merged
merged 9 commits into from
May 23, 2024
Merged

NPC breathing and blinking #356

merged 9 commits into from
May 23, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented May 6, 2024 •
edited
Loading

To test

  1. Load Lab scene
  2. Activate GVRSingletons --> FeatureFlags --> enableNpcEyeBlinking
  3. Spawn an NPC and play his animation
  4. After the animation you should see NPC blinking (too long, but it works already) and breathing

Boundary:

  • The feature for breathing won't really work in main game as NPCs are always doing something.
  • Blinking is behind a feature flag so that we can pause implementation and rework in the future.

image

@JaXt0r JaXt0r changed the title add(IdleAnimation): Whenever there is no next animation and NPC has n… NPC breathing (idle animations) May 6, 2024
@JaXt0r JaXt0r linked an issue May 8, 2024 that may be closed by this pull request
HeadMorph - implement weights, blending, and multiple morphs at the same time #357
Open
7 tasks
@JaXt0r JaXt0r requested a review from Redreaper666 May 23, 2024 03:17
@JaXt0r JaXt0r marked this pull request as ready for review May 23, 2024 03:17
@JaXt0r JaXt0r changed the title NPC breathing (idle animations) NPC breathing and blinking May 23, 2024
Redreaper666
Redreaper666 approved these changes May 23, 2024
View reviewed changes
Copy link

@Redreaper666 Redreaper666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EyeBlink and Breathing works as intended and can be merged.

@JaXt0r JaXt0r merged commit eca2eab into main May 23, 2024
@JaXt0r JaXt0r deleted the feature/npc-breathing branch May 23, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Redreaper666 Redreaper666 Redreaper666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HeadMorph - implement weights, blending, and multiple morphs at the same time
2 participants
@JaXt0r @Redreaper666