feat(#1423): Add table page (code review needed) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for abgov-ui-component-docs failed.
|
9 tasks
|
chrisolsen
reviewed
Nov 15, 2023
src/routes/components/Table.tsx
Outdated
Comment on lines
251
to
269
| ]; | ||
| setUsers(_users); | ||
| }, []); | ||
| function sortData(sortBy: string, sortDir: number) { | ||
| const _users = [...users]; | ||
| _users.sort((a: any, b: any) => { | ||
| return (a[sortBy] > b[sortBy] ? 1 : -1) * sortDir; | ||
| }); | ||
| setUsers(_users); | ||
| } | ||
| return ( | ||
| <GoATable onSort={sortData}> | ||
| <thead> | ||
| <tr> | ||
| <th> | ||
| <GoATableSortHeader name="firstName">First name</GoATableSortHeader> |
There was a problem hiding this comment.
The code snippets allow for whitespace (storybook didn't). So we should keep things readable by adding whitespace where necessary.
There was a problem hiding this comment.
Thank you @chrisolsen I added the space.
vanessatran-ddi
changed the title
vanessatran-ddi
force-pushed
the
feat/table-page
branch
from
d520648 to
5b890f6
Compare
|
Signed-off-by: Vanessa Tran <[email protected]>
vanessatran-ddi
force-pushed
the
feat/table-page
branch
from
5b890f6 to
729279d
Compare
chrisolsen
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table page:
