Skip to content

Commit

Permalink
feat(#2991)!: bump up angular and react version
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This upgrade introduces changes prefix goa to goab for both Angular and React components.
  • Loading branch information
vanessatran-ddi authored and chrisolsen committed Jan 7, 2025
1 parent db76130 commit e95e00d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion libs/angular-components/src/lib/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function dispatchError(el: HTMLElement, name: string, msg: string) {
}

export class FormValidator {
private validators: Record<string, FieldValidator[]>;
private readonly validators: Record<string, FieldValidator[]>;
constructor(validators?: Record<string, FieldValidator[]>) {
this.validators = validators || {};
}
Expand Down
4 changes: 1 addition & 3 deletions libs/react-components/src/lib/filter-chip/filter-chip.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { useEffect, useRef } from "react";
import { Margins, GoabFilterChipTheme } from "@abgov/ui-components-common";

export type GoAFilterChipTheme = "outline" | "filled";

interface WCProps extends Margins {
ref: React.RefObject<HTMLElement>;
icontheme: GoabFilterChipTheme;
Expand All @@ -21,7 +19,7 @@ declare global {

export interface GoAFilterChipProps extends Margins {
onClick?: () => void;
iconTheme?: GoAFilterChipTheme;
iconTheme?: GoabFilterChipTheme;
error?: boolean;
content: string;
testId?: string;
Expand Down

0 comments on commit e95e00d

Please sign in to comment.