Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Table's variant relaxed and normal #1466

Closed
vanessatran-ddi opened this issue Nov 15, 2023 · 8 comments · Fixed by #1788
Closed

[Bug]: Table's variant relaxed and normal #1466

vanessatran-ddi opened this issue Nov 15, 2023 · 8 comments · Fixed by #1788
Assignees
Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.

Comments

@vanessatran-ddi
Copy link
Collaborator

Describe the bug

The variant relaxed and normal make no difference.
image
image

They are no different, regarding about the padding in the table cell.
Definition of "variant"
variant: A relaxed variant of the table with more vertical padding for the cells

Provide Code

No response

To Reproduce

https://deploy-preview-27--abgov-ui-component-docs.netlify.app/components/table
Sandbox, when changing the variant property, makes no difference.

Relevant console log output

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

@Spark450
Copy link
Collaborator

Spark450 commented Nov 23, 2023

comment made in error.

@bdfranck
Copy link
Collaborator

bdfranck commented Apr 12, 2024

The CSS selectors for relaxed rows (and a sticky header) don't work because the goa-table element doesn't get a relaxed or sticky class.

goa-table.relaxed td {
padding: 1rem;
}
goa-table.sticky thead {
position: sticky;
top: 0;
}

It looks like the wrapper div in the element's shadow DOM has the classes instead 👀.

Image

I'm not sure how best to approach it. I'll need to spend more time researching how to style a slotted element in this situation. 🤔

@syedszeeshan syedszeeshan self-assigned this Apr 15, 2024
@ArakTaiRoth ArakTaiRoth moved this from 🔖 Ready to 🏗 In progress in Design System Backlog Apr 15, 2024
@syedszeeshan syedszeeshan removed their assignment Apr 15, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 17, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 17, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 18, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 18, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 18, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 19, 2024
@ArakTaiRoth ArakTaiRoth moved this from 🏗 In progress to Testing in Design System Backlog Apr 19, 2024
@ArakTaiRoth ArakTaiRoth linked a pull request Apr 19, 2024 that will close this issue
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue Apr 22, 2024
@ArakTaiRoth ArakTaiRoth moved this from Testing to 👀 In review in Design System Backlog Apr 24, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to Alpha in Design System Backlog Apr 24, 2024
@tzuge
Copy link
Collaborator

tzuge commented Apr 24, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.44 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Apr 24, 2024
@tzuge
Copy link
Collaborator

tzuge commented Apr 30, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented May 13, 2024

🎉 This issue has been resolved in version 1.20.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label May 13, 2024
@tzuge
Copy link
Collaborator

tzuge commented May 13, 2024

🎉 This issue has been resolved in version 4.20.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ArakTaiRoth ArakTaiRoth moved this from Alpha to ✅ Done in Design System Backlog May 13, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants