Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2284): radio group tabindex order #2323

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(#2284): radio group tabindex order #2323

merged 1 commit into from
Feb 14, 2025

Conversation

BumbleB2na
Copy link
Collaborator

@BumbleB2na BumbleB2na commented Dec 23, 2024 •
edited
Loading

Before (the change)

Reproduced problem with tabindex order:

PlaygroundReact.-.Google.Chrome.2024-12-23.17-11-32.mp4

After (the change)

Result:

PlaygroundReact.-.Google.Chrome.2024-12-23.17-19-24.mp4

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

Tested result on chrome in web-components playground and in react playground:
image

@BumbleB2na BumbleB2na linked an issue Dec 24, 2024 that may be closed by this pull request
Input: Value of 0 will not be displayed #2299
Open
@ArakTaiRoth ArakTaiRoth removed a link to an issue Jan 2, 2025
Input: Value of 0 will not be displayed #2299
Open
@ArakTaiRoth ArakTaiRoth linked an issue Jan 2, 2025 that may be closed by this pull request
Radio: Tab order broken on simple form #2284
Closed
@ArakTaiRoth ArakTaiRoth marked this pull request as ready for review January 22, 2025 20:41
@ArakTaiRoth ArakTaiRoth merged commit ba15953 into GovAlta:alpha Feb 14, 2025
1 check passed
@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 1.32.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Feb 14, 2025
@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 4.2.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 6.2.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Feb 14, 2025
@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 14, 2025

🎉 This issue has been resolved in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisolsen chrisolsen chrisolsen approved these changes

@vanessatran-ddi vanessatran-ddi vanessatran-ddi approved these changes

@ArakTaiRoth ArakTaiRoth Awaiting requested review from ArakTaiRoth ArakTaiRoth is a code owner

@syedszeeshan syedszeeshan Awaiting requested review from syedszeeshan syedszeeshan is a code owner

Assignees
No one assigned
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio: Tab order broken on simple form
5 participants
@BumbleB2na @tzuge @chrisolsen @vanessatran-ddi @ArakTaiRoth