-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/bump angular react version #2336
Closed
vanessatran-ddi
wants to merge
30
commits into
GovAlta:alpha
from
vanessatran-ddi:fix/bump-angular-react-version
Closed
Fix/bump angular react version #2336
vanessatran-ddi
wants to merge
30
commits into
GovAlta:alpha
from
vanessatran-ddi:fix/bump-angular-react-version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge alpha to main
Production Release - November 27 / 2023
Production Release - December 7 / 2023
Production Release - January 17 / 2024
Production Release - February 21 / 2024
Production Release: February 22 / 2024
Production Release: Trigger breaking change in Angular
fix: remove previous change and bump angular up to v3.0.1
Production Release - March 20 / 2024
Production Hotfix: March 27 / 2024
Production Hotfix - April 3 / 2024
Production Hotfix - April 4 / 2024
Production Hotfix: April 9, 2024
Production Release: April 24 / 2024
Production Release - May 13 / 2024
Production Release - June 11 / 2024
Production Release - June 27 / 2024
Production Release - July 18 / 2024
Hotfix Release: July 22 / 2024
Production Release - July 30 / 2024
Production Release - August 29 / 2024
Production Release - September 11 / 2024
Production Release - September 24 / 2024
Production Release - September 26 / 2024
Production Release - October 30 / 2024
Production Release - December 19 / 2024
…lishing-different-version fix(GovAlta#2291): add workflow to release lts
BREAKING CHANGE: This upgrade introduces changes prefix goa to goab for both Angular and React components.
d2ddeec
to
87d5a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (the change)
It is releasing angular-components to alpha on npm as 3.0.0-alpha.11 instead of 4.0.0-alpha, react-components as 5.0.0-alpha.17 instead of 6.0.0-alpha. I was adding a commit message with ! which is expected to bump the version.
The strange thing was I had another branch https://github.com/GovAlta/ui-components/tree/alpha-dry-run-release which I checked out from alpha a week ago, and run dry-run on it, which bumps the version!
So after I made 2 branches identical, till the tags attached to it, the dry-run provided the version exactly like the alpha. And dive into the running log, I see this:
react-v4.16.0...react-v5.0.0-alpha-dry-run-release.1
semantic-release picked up the above tag to determine which is the next version (same with angular-components), and because they picked the wrong tag 4.16.0 instead of 5.X.X, so they said the next version is 5.0.0-alpha.1
and because on npm published has more than 5.0.0-alpha.1 , it increments the version 5 with the last number automatically to prevent the conflict with npm.
So I tested by using the below command:
git show react-v5.4.1
commit 9f131ab (tag: web-components-v1.29.1, tag: react-v5.4.1, tag: angular-v3.2.2, GovAlta/lts, lts)
Merge: a78ccba 207a9b8
Author: Minh Thy Tran [email protected]
Date: Mon Dec 23 10:47:01 2024 -0700
fix(#2291): add workflow to release lts
thytran142@Trans-MacBook-Pro ui-components % git log --oneline --decorate --graph | grep react-v5.4.1
And there are nothing returned after I checked git log against with react-v5.4.1
So alpha branch and alpha-dry-run-release branch don’t have the tag in its ancestry. To fix it, I need to merge the branch with the tag.
thytran142@Trans-MacBook-Pro ui-components % git merge react-v5.4.1
Auto-merging .releaserc.json
CONFLICT (content): Merge conflict in .releaserc.json
Auto-merging libs/angular-components/src/lib/value-directive.ts
Auto-merging libs/react-components/src/lib/input/input.tsx
Automatic merge failed; fix conflicts and then commit the result.
thytran142@Trans-MacBook-Pro ui-components % git merge react-v5.4.1
Already up to date.
After (the change)
So this PR is to:
alpha
branch has a history of tags aligned which makes semantic release bumps the correct versionMake sure that you've checked the boxes below before you submit the PR
Steps needed to test