use a separate string when showing errors of background app update check

GrapheneOS · Jul 18, 2024 · 5f306e5 · 5f306e5
1 parent 1367705
commit 5f306e5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/app/src/main/java/app/grapheneos/apps/autoupdate/UpdateCheckJob.kt b/app/src/main/java/app/grapheneos/apps/autoupdate/UpdateCheckJob.kt
@@ -141,7 +141,7 @@ fun showAllUpToDateNotification() {
 fun showUpdateCheckFailedNotification(repoUpdateError: RepoUpdateError) {
     Notifications.builder(Notifications.CH_BACKGROUND_UPDATE_CHECK_FAILED).run {
         setSmallIcon(R.drawable.ic_error)
-        setContentTitle(R.string.unable_to_fetch_app_list)
+        setContentTitle(R.string.app_update_check_failed)
         setContentIntent(ErrorDialog.createPendingIntent(repoUpdateError))
         show(Notifications.ID_AUTO_UPDATE_JOB_STATUS)
     }

diff --git a/app/src/main/java/app/grapheneos/apps/core/Errors.kt b/app/src/main/java/app/grapheneos/apps/core/Errors.kt
@@ -105,7 +105,8 @@ private fun networkErrorResStringOrZero(e: Throwable) = when (e) {
 
 @Parcelize
 class RepoUpdateError(val throwable: Throwable, val wasUpdateManuallyRequested: Boolean) : ErrorTemplate() {
-    override fun titleResource() = R.string.unable_to_fetch_app_list
+    override fun titleResource() = if (wasUpdateManuallyRequested)
+        R.string.unable_to_fetch_app_list else R.string.app_update_check_failed
 
     fun isNotable() = when (throwable) {
         is ConnectException,

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -99,6 +99,8 @@
     <string name="notif_download_failed">Download failed</string>
 
     <string name="unable_to_fetch_app_list">Unable to fetch the list of apps</string>
+    <string name="app_update_check_failed">App update check failed</string>
+
     <string name="main_screen_unable_to_fetch_app_list_initial">Unable to fetch the list of apps, swipe down to try again.</string>
 
     <string name="uninstall_failed">Uninstall failed</string>