-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx Issue#343 #365
base: master
Are you sure you want to change the base?
FIx Issue#343 #365
Conversation
Thanks for the pull requests @suvigyavijay ! Apparently some of the tests are broken by your changes: https://travis-ci.org/Grasia/teem/builds/207278341 The failures are highlighted in RED, and you can identify what the test tried to do by reading the definition. For instance the first refers to an user trying to create a need when being logged in:
Could you please try to correct this before we merge your changes? |
@atfornes Actually, I checked out to the "Change Travis badge and repo url" commit(latest commit on your repo) and ran the tests on my local machine. The tests were already broken in the commit, so I ignored them while making the pull request. I'll try to fix them too but I don't think my pull request creates any problem. |
Ok I tried but I fixed the error locally but the error still remains on Travis-CI. @atfornes Can you help me out? It says
Firstly I am not able to figure out which element it is talking about. Also what is the needs page? Is it the one thats regarding addition of Tasks? |
Sorry @suvigyavijay, but the contributions of GSoC applicants should wait as we explain in the wiki: https://cyber.harvard.edu/gsoc/GSoC_FAQ#Can_I_start_contributing_now.3F.21 I am sorry I have not let you know earlier, but I forgot about this agreement we have to follow. Thanks again anyway :) . |
The headers were hidden by grey toolbar couldn't have been fixed by just adding padding and negative margin.
I added extra padding to the navbar-top and removed it from the pad-toolbar to make it work.
Or either we can edit the JS that's manipulating the pad-toolbar style when we scroll down, but I was unable to locate the script doing so. Maybe it's a vendor script named ngSticky.
Kindly review the pull request.
Regards
Suvigya Vijay