Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout column problem when GF Styles Pro enabled #1498

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Feb 25, 2024

Description

Move the grid CSS classes first in the class order, so that they aren't removed due to an mPDF processing bug when there are a lot of classes.

Testing instructions

  1. Create a form with multiple drag and drop columns
  2. On fields in columns, add 10 different CSS classes to those field
  3. View the PDF and see those fields are not in columns.

This problem occurs because we needed to limit the number of CSS classes that can be included on fields.

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Move the grid CSS classes first in the class order, so that they aren't removed due to an mPDF processing bug when there are a lot of classes.
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (b9d16b6) to head (46c4a1e).

Additional details and impacted files
@@             Coverage Diff              @@
##           development    #1498   +/-   ##
============================================
  Coverage        77.03%   77.03%           
============================================
  Files              243      243           
  Lines            12447    12447           
  Branches           370      370           
============================================
  Hits              9589     9589           
  Misses            2850     2850           
  Partials             8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 merged commit f27ba77 into development Feb 26, 2024
16 checks passed
@jakejackson1 jakejackson1 deleted the drag-and-drop-columns-css-issue branch February 26, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant