Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve column support when there is a spacer #1590

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Nov 10, 2024

Description

Better calculate when Gravity Forms would insert a spacer into the form, so we can correctly end a row in the PDF.

Testing instructions

  1. Create a form with drag and drop columns
  2. Set the width of a field in a column to only take up some of the space
  3. Add additional rows and columns with a similar configuration
  4. Add a PDF to the form
  5. Preview the PDF

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

@jakejackson1 jakejackson1 changed the base branch from development to hot-patch November 10, 2024 23:33
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (bb5a359) to head (af25986).
Report is 5 commits behind head on hot-patch.

Files with missing lines Patch % Lines
src/Helper/Helper_Field_Container_Gf25.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           hot-patch    #1590      +/-   ##
=============================================
- Coverage      75.70%   75.68%   -0.02%     
=============================================
  Files            251      251              
  Lines          13606    13609       +3     
  Branches         370      370              
=============================================
  Hits           10300    10300              
- Misses          3298     3301       +3     
  Partials           8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 marked this pull request as ready for review November 11, 2024 00:04
Better calculate when Gravity Forms would insert a spacer into the form, so we can correctly end a row in the PDF.
@jakejackson1 jakejackson1 merged commit 340c785 into hot-patch Nov 11, 2024
10 of 11 checks passed
@jakejackson1 jakejackson1 deleted the column-spacer branch November 11, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant