Implement option to display links in search sidebar. #20638
Conversation
linuspahl
force-pushed
the
sidebar-page-links
branch
from
051c724
to
108b2b7
Compare
linuspahl
force-pushed
the
sidebar-page-links
branch
from
8870932
to
8acb258
Compare
| @@ -500,6 +509,7 @@ declare module 'graylog-web-plugin/plugin' { | |||
| 'views.hooks.copyPageToDashboard'?: Array<CopyParamsToView>; | |||
| 'views.hooks.removingWidget'?: Array<RemovingWidgetHook>; | |||
| 'views.overrides.widgetEdit'?: Array<React.ComponentType<OverrideProps>>; | |||
| 'views.sidebar.links'?: Array<SidebarLink>; | |||
There was a problem hiding this comment.
I think it would be more useful to have something like views.sidebar.topSection or searchSystemSection and the Items can have some flag isLink. Having just links means that there will be just links and there might be multiple links and I'm not sure that we will add more different links (except something similar to DWH). Also if we would decided to have another section with some links it might be confusing.
There was a problem hiding this comment.
I tried to improve the name.
| }; | ||
|
|
||
| const StreamsFilter = ({ disabled, value, streams, onChange }: Props) => { | ||
| const StreamsFilter = ({ disabled, value, streams, onChange, multi }: Props) => { |
There was a problem hiding this comment.
Why do we need this change in this PR?
There was a problem hiding this comment.
This is necessary for making the streams filter reusable and I did not want to create another PR for this small change.
linuspahl
force-pushed
the
sidebar-page-links
branch
from
6002347
to
e086fda
Compare
linuspahl
force-pushed
the
sidebar-page-links
branch
from
97bce28
to
6ba65b6
Compare
Description
Motivation and Context
This PR adds the option to render links in the search sidebar via the plugin system.
Hover styling:
Active styling:
/nocl