-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle input setup mode #20715
Handle input setup mode #20715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as described, code looking good, found a type nitpick but I guess that's because the backend is not ready yet so I will approve.
|
||
export interface Input extends InputBase { | ||
attributes: { | ||
[type: string]: any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we safe type these or are they unknown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they differ based on the input type.
|
||
export interface ConfiguredInput extends InputBase { | ||
configuration: { | ||
[type: string]: any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they differ based on the input type.
Description
Part of #20530
Frontend changes for handling the setup mode on inputs.
This PR:
setup_mode
value totrue
setup_mode
value tofalse
The backend is not yet done but the frontend can be reviewed and tested in isolation by changing the condition and checking if the right calls are made.
/nocl
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: