SearchType.Result proper deserialization #21573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
approved these changes
Feb 10, 2025
janheise
approved these changes
Feb 10, 2025
luk-kaminski
deleted the
data_lake/search_type_result_deserialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SearchType.Result proper deserialization.
/jpd Graylog2/graylog-plugin-enterprise#9685
/nocl
Motivation and Context
So far, we seemed to serialize
SearchType.Resultinstances to JSON, but never deserialize them back.With a move towards storing results of search job in MongoDB, we need proper deserialization as well.
Despite the fact that only
IcebergRowsList.Resultis needed at this point, I am adding support for allSearchType.Resultsubclasses.Types of changes
Checklist: