-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mongodb-driver version to 3.10.1 #5736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of test failures in the Jenkins and TravisCI builds which seem to be related to the driver update. We might need to update mongojack as well.
Looks like fongo is not compatible with newer mongodb-driver versions :/ |
Okay, how about doing the - userInfo = userAndHostInformation.substring(0, idx);
+ userInfo = userAndHostInformation.substring(0, idx).replace("+", "%2B"); It's not really nice but it would allow us to work around the issue until we can refactor/update our testing infrastructure. @mariussturm What do you think? |
Well we need some partial parsing of the connection string to only apply the replacement on the username and password. So that we replicate the behaviour of the mongo-driver code. If this is not too much overhead we can do it like this. |
Update mongodb client library to latest version
Motivation and Context
This fixes #5680
How Has This Been Tested?
Regression test added
Screenshots (if appropriate):
Types of changes
Checklist: