Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb-driver version to 3.10.1 #5736

Closed
wants to merge 8 commits into from
Closed

Conversation

mariussturm
Copy link
Contributor

Update mongodb client library to latest version

Motivation and Context

This fixes #5680

How Has This Been Tested?

Regression test added

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of test failures in the Jenkins and TravisCI builds which seem to be related to the driver update. We might need to update mongojack as well.

@bernd bernd self-assigned this Mar 1, 2019
@mariussturm
Copy link
Contributor Author

Looks like fongo is not compatible with newer mongodb-driver versions :/
fakemongo/fongo#357

@bernd
Copy link
Member

bernd commented Mar 1, 2019

Looks like fongo is not compatible with newer mongodb-driver versions :/
fakemongo/fongo#357

Okay, how about doing the + character replacement on our own as a workaround? That's what the MongoDB Java driver is doing:

-            userInfo = userAndHostInformation.substring(0, idx);
+            userInfo = userAndHostInformation.substring(0, idx).replace("+", "%2B");

It's not really nice but it would allow us to work around the issue until we can refactor/update our testing infrastructure.

@mariussturm What do you think?

@mariussturm
Copy link
Contributor Author

Well we need some partial parsing of the connection string to only apply the replacement on the username and password. So that we replicate the behaviour of the mongo-driver code. If this is not too much overhead we can do it like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graylog cannot authenticate on MongoDB if password contains the sign +
2 participants