Switch back to a repackaged and fixed version of java-grok (#5800) #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch back to a repackaged and fixed version of java-grok
To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.
See: graylog-labs/java-grok#2
This also adds a test for the Grok extractor to make sure that using
underscores works.
Fixes #5704
Fixes #5563
* Fix GrokPatternService#extractPatternNames and add a test for it
* Add missing license header to GrokPatternServiceTest
* Add test for named group with underscore
Prior to this change, there was no test for named groups
with underscores in the FunctionSnippetsTest
This change enhances the grok() test to run with a
named group with underscore.
(cherry picked from commit e642a41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.
See: graylog-labs/java-grok#2
This also adds a test for the Grok extractor to make sure that using
underscores works.
Fixes #5704
Fixes #5563
Fix GrokPatternService#extractPatternNames and add a test for it
Add missing license header to GrokPatternServiceTest
Add test for named group with underscore
Prior to this change, there was no test for named groups
with underscores in the FunctionSnippetsTest
This change enhances the grok() test to run with a
named group with underscore.
(cherry picked from commit e642a41)