Merge pull request #410 from pranavkparti/transfer-request-claim

fix: transfer request claim is optional parameter
Greenstand · Aug 27, 2023 · d74df33 · d74df33
2 parents 0d9aa72 + d9dce33
commit d74df33
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/server/handlers/transferHandler.spec.js b/server/handlers/transferHandler.spec.js
@@ -146,6 +146,7 @@ describe('transferRouter', () => {
           tokens: ['1'],
           sender_wallet: 'wallet1',
           receiver_wallet: 'wallet2',
+          claim: false,
         },
         authenticatedWalletId,
       ),

diff --git a/server/handlers/transferHandler/index.js b/server/handlers/transferHandler/index.js
@@ -8,11 +8,11 @@ const {
 } = require('./schemas');
 
 const transferPost = async (req, res) => {
-  await transferPostSchema.validateAsync(req.body, { abortEarly: false });
+  const validatedData = await transferPostSchema.validateAsync(req.body, { abortEarly: false });
   const transferService = new TransferService();
 
   const { result, status } = await transferService.initiateTransfer(
-    req.body,
+    validatedData,
     req.wallet_id,
   );
 

diff --git a/server/handlers/transferHandler/schemas.js b/server/handlers/transferHandler/schemas.js
@@ -12,16 +12,15 @@ const transferPostSchema = Joi.alternatives()
         tokens: Joi.array().items(Joi.string()).required().unique(),
         sender_wallet: Joi.alternatives().try(Joi.string()).required(),
         receiver_wallet: Joi.alternatives().try(Joi.string()).required(),
-        // TODO: add boolean for claim, but default to false.
-        claim: Joi.boolean(),
+        claim: Joi.boolean().default(false),
       }),
       otherwise: Joi.object({
         bundle: Joi.object({
           bundle_size: Joi.number().min(1).max(10000).integer(),
         }).required(),
         sender_wallet: Joi.string().required(),
         receiver_wallet: Joi.string().required(),
-        claim: Joi.boolean().required(),
+        claim: Joi.boolean().default(false),
       }),
     },
   );