Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.10 validations fix #428

Open
wants to merge 2 commits into
base: v1.10
Choose a base branch
from

Conversation

pranavkparti
Copy link
Collaborator

Description

The schema validations are fixed for errors and parameters.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
The validation is inconsistent across the endpoints.

What is the new behavior?

The changes include:

  • GET /tokens/:id/transactions -> removed unnecessary parameters, added validation for id
  • GET /tokens/:id -> added validation for id
  • GET /trust_relationships -> added limit as a required parameter
  • Added min, max, for limit and offset
  • etc.

Breaking change

Does this PR introduce a breaking change?
No.

Other useful information

None.

@pranavkparti pranavkparti requested a review from Kpoke September 14, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant