Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some missing tooltips #1626

Merged
merged 7 commits into from
Aug 3, 2024
Merged

Conversation

qwer523
Copy link
Contributor

@qwer523 qwer523 commented Jul 30, 2024

What

Fix XEI Visible behavior. Prevent the registration of categories and recipes.
Fix Representative Recipes. Show them in all XEI.
Fix missing lang key

@qwer523 qwer523 requested a review from a team as a code owner July 30, 2024 10:34
@qwer523
Copy link
Contributor Author

qwer523 commented Jul 30, 2024

By the way, I removed the custom logic from the Research Station because it looked useless and was specifically designed for Scanner.

@screret
Copy link
Member

screret commented Jul 30, 2024

By the way, I removed the custom logic from the Research Station because it looked useless and was specifically designed for Scanner.

It should also be on the research station.

@qwer523
Copy link
Contributor Author

qwer523 commented Jul 30, 2024

By the way, I removed the custom logic from the Research Station because it looked useless and was specifically designed for Scanner.

It should also be on the research station.

It seems unnecessary for the research station to have the function of replicating DataStick, as this recipe does not require CWU

@qwer523
Copy link
Contributor Author

qwer523 commented Jul 30, 2024

It doesn't look like it was designed for a research station. The recipe type of the recipe it generates is scanner, which can cause problems.

# Conflicts:
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/api/item/OpticalPipeBlockItem.java
#	src/main/java/com/gregtechceu/gtceu/data/lang/BlockLang.java
@screret screret merged commit d3ca95e into GregTechCEu:1.20.1 Aug 3, 2024
2 checks passed
@screret screret changed the title misc add some missing tooltips Aug 16, 2024
@screret screret added type: feature New feature or request type: bug Something isn't working and removed type: feature New feature or request labels Aug 16, 2024
screret pushed a commit that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants