Skip to content

Commit

Permalink
chore: per review
Browse files Browse the repository at this point in the history
  • Loading branch information
discord9 committed May 15, 2024
1 parent a9f16e8 commit b4708c2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/flow/src/adapter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ mod worker;
pub const PER_REQ_MAX_ROW_CNT: usize = 8192;
// TODO: refactor common types for flow to a separate module
/// FlowId is a unique identifier for a flow task
pub type FlowId = u64;
pub type FlowId = u32;
pub type TableName = [String; 3];
2 changes: 1 addition & 1 deletion src/flow/src/adapter/table_source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl TableSource {
.map(|name| [name.catalog_name, name.schema_name, name.table_name])
}

/// query metasrv about the table name and table id
/// query metasrv about the `TableInfoValue` and table id
pub async fn get_table_info_value(
&self,
table_id: &TableId,
Expand Down
2 changes: 1 addition & 1 deletion src/flow/src/adapter/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub fn column_schemas_to_proto(
ColumnDataTypeWrapper::try_from(c.data_type.clone())
.map(|w| w.to_parts())
.map_err(BoxedError::new)
.with_context(|_| ExternalSnafu)
.context(ExternalSnafu)
})
.try_collect()?;

Expand Down

0 comments on commit b4708c2

Please sign in to comment.