refactor: use '#[snafu(source(from()))'

src/cmd/src/datanode.rs

@@ -143,7 +143,6 @@ impl StartCommand {
                     self.config_file.as_deref(),
                     self.env_prefix.as_ref(),
                 )
-                .map_err(Box::new)
                 .context(LoadLayeredConfigSnafu)?,
             )?,
         )))

src/cmd/src/error.rs

@@ -208,7 +208,7 @@ pub enum Error {
 
     #[snafu(display("Failed to load layered config"))]
     LoadLayeredConfig {
-        #[snafu(source)]
+        #[snafu(source(from(common_config::error::Error, Box::new)))]
         source: Box<common_config::error::Error>,
         #[snafu(implicit)]
         location: Location,

src/cmd/src/frontend.rs

@@ -163,7 +163,6 @@ impl StartCommand {
                     self.config_file.as_deref(),
                     self.env_prefix.as_ref(),
                 )
-                .map_err(Box::new)
                 .context(LoadLayeredConfigSnafu)?,
             )?,
         )))

src/cmd/src/metasrv.rs

@@ -136,7 +136,6 @@ impl StartCommand {
                     self.config_file.as_deref(),
                     self.env_prefix.as_ref(),
                 )
-                .map_err(Box::new)
                 .context(LoadLayeredConfigSnafu)?,
             )?,
         )))

src/cmd/src/standalone.rs

@@ -22,9 +22,8 @@ use cache::{
 };
 use catalog::kvbackend::KvBackendCatalogManager;
 use clap::Parser;
-use common_config::Configurable;
 use common_catalog::consts::{MIN_USER_FLOW_ID, MIN_USER_TABLE_ID};
-use common_config::{metadata_store_dir, KvBackendConfig};
+use common_config::{metadata_store_dir, Configurable, KvBackendConfig};
 use common_meta::cache::LayeredCacheRegistryBuilder;
 use common_meta::cache_invalidator::CacheInvalidatorRef;
 use common_meta::ddl::flow_meta::{FlowMetadataAllocator, FlowMetadataAllocatorRef};
@@ -64,9 +63,9 @@ use snafu::{OptionExt, ResultExt};
 
 use crate::error::{
     BuildCacheRegistrySnafu, CacheRequiredSnafu, CreateDirSnafu, IllegalConfigSnafu,
-    InitDdlManagerSnafu, InitMetadataSnafu, InitTimezoneSnafu, Result, ShutdownDatanodeSnafu,
-    ShutdownFrontendSnafu, StartDatanodeSnafu, StartFrontendSnafu, StartProcedureManagerSnafu,
-    StartWalOptionsAllocatorSnafu, StopProcedureManagerSnafu,LoadLayeredConfigSnafu
+    InitDdlManagerSnafu, InitMetadataSnafu, InitTimezoneSnafu, LoadLayeredConfigSnafu, Result,
+    ShutdownDatanodeSnafu, ShutdownFrontendSnafu, StartDatanodeSnafu, StartFrontendSnafu,
+    StartProcedureManagerSnafu, StartWalOptionsAllocatorSnafu, StopProcedureManagerSnafu,
 };
 use crate::options::{GlobalOptions, Options};
 use crate::App;
@@ -295,7 +294,6 @@ impl StartCommand {
                     self.config_file.as_deref(),
                     self.env_prefix.as_ref(),
                 )
-                .map_err(Box::new)
                 .context(LoadLayeredConfigSnafu)?,
             )?,
         )))

src/datanode/src/error.rs

@@ -364,6 +364,7 @@ pub enum Error {
     TomlFormat {
         #[snafu(implicit)]
         location: Location,
+        #[snafu(source(from(common_config::error::Error, Box::new)))]
         source: Box<common_config::error::Error>,
     },
 }

src/datanode/src/service.rs

@@ -76,12 +76,7 @@ impl<'a> DatanodeServiceBuilder<'a> {
         if self.enable_http_service {
             let http_server = HttpServerBuilder::new(self.opts.http.clone())
                 .with_metrics_handler(MetricsHandler)
-                .with_greptime_config_options(
-                    self.opts
-                        .to_toml()
-                        .map_err(Box::new)
-                        .context(TomlFormatSnafu)?,
-                )
+                .with_greptime_config_options(self.opts.to_toml().context(TomlFormatSnafu)?)
                 .build();
             let addr: SocketAddr = self.opts.http.addr.parse().context(ParseAddrSnafu {
                 addr: &self.opts.http.addr,

src/frontend/src/error.rs

@@ -345,6 +345,7 @@ pub enum Error {
     TomlFormat {
         #[snafu(implicit)]
         location: Location,
+        #[snafu(source(from(common_config::error::Error, Box::new)))]
         source: Box<common_config::error::Error>,
     },
 

src/frontend/src/frontend.rs

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use common_telemetry::logging::{LoggingOptions, TracingOptions};
 use common_config::config::Configurable;
+use common_telemetry::logging::{LoggingOptions, TracingOptions};
 use meta_client::MetaClientOptions;
 use serde::{Deserialize, Serialize};
 use servers::export_metrics::ExportMetricsOption;

src/frontend/src/server.rs

@@ -172,7 +172,7 @@ where
         let opts = self.opts.clone();
         let instance = self.instance.clone();
 
-        let toml = opts.to_toml().map_err(Box::new).context(TomlFormatSnafu)?;
+        let toml = opts.to_toml().context(TomlFormatSnafu)?;
         let opts: FrontendOptions = opts.into();
 
         let handlers = ServerHandlers::default();

src/meta-srv/src/bootstrap.rs

@@ -74,9 +74,7 @@ impl MetasrvInstance {
         let httpsrv = Arc::new(
             HttpServerBuilder::new(opts.http.clone())
                 .with_metrics_handler(MetricsHandler)
-                .with_greptime_config_options(
-                    opts.to_toml().map_err(Box::new).context(TomlFormatSnafu)?,
-                )
+                .with_greptime_config_options(opts.to_toml().context(TomlFormatSnafu)?)
                 .build(),
         );
         // put metasrv into plugins for later use

src/meta-srv/src/error.rs

@@ -837,6 +837,7 @@ pub enum Error {
     TomlFormat {
         #[snafu(implicit)]
         location: Location,
+        #[snafu(source(from(common_config::error::Error, Box::new)))]
         source: Box<common_config::error::Error>,
     },
 }