-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: truncate table in standalone mode #2090
Merged
evenyag
merged 7 commits into
GreptimeTeam:develop
from
DevilExileSu:feat/standalone-truncate
Aug 8, 2023
Merged
feat: truncate table in standalone mode #2090
evenyag
merged 7 commits into
GreptimeTeam:develop
from
DevilExileSu:feat/standalone-truncate
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2090 +/- ##
===========================================
- Coverage 84.87% 84.57% -0.30%
===========================================
Files 687 689 +2
Lines 108586 108988 +402
===========================================
+ Hits 92163 92182 +19
- Misses 16423 16806 +383 |
DevilExileSu
force-pushed
the
feat/standalone-truncate
branch
from
August 4, 2023 13:25
a6104e5
to
a1db375
Compare
evenyag
reviewed
Aug 7, 2023
evenyag
reviewed
Aug 8, 2023
evenyag
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
WenyXu
approved these changes
Aug 8, 2023
@DevilExileSu Could you please format the code? |
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
DevilExileSu
force-pushed
the
feat/standalone-truncate
branch
from
August 8, 2023 09:58
8c8ff38
to
a35715f
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: impl table procedure in standalone mode * chore: remove useless changes * test: add some tests * Update src/table-procedure/src/truncate.rs Co-authored-by: Yingwen <[email protected]> * CR * Update src/datanode/src/sql/truncate_table.rs Co-authored-by: Yingwen <[email protected]> * chore: fmt --------- Co-authored-by: Yingwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
RegionWriter
lock.RegionMetaAction::Truncate
to storecommitted_sequence
and persist it for recovery from the manifest.obsolete
.RegionMetaAction::Truncate
.committed_sequence
fromRegionMetaAction::Truncate
as the Version'sflushed_sequence
.Checklist
Refer to a related PR or issue link (optional)