-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bugs related to merge scan #2118
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works not only on your machine ......
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Lei, HUANG <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #2118 +/- ##
===========================================
- Coverage 84.94% 84.51% -0.43%
===========================================
Files 687 687
Lines 108052 108596 +544
===========================================
- Hits 91786 91784 -2
- Misses 16266 16812 +546 |
* fix: prevent optimize merge scan, mark distinct as unsupported Signed-off-by: Ruihang Xia <[email protected]> * fix some other problems Signed-off-by: Ruihang Xia <[email protected]> * fix unit tests Signed-off-by: Ruihang Xia <[email protected]> * remove deadcode Signed-off-by: Ruihang Xia <[email protected]> * add some comments Signed-off-by: Ruihang Xia <[email protected]> * Update src/query/src/optimizer/type_conversion.rs Co-authored-by: Lei, HUANG <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]> Co-authored-by: Lei, HUANG <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fix some bugs related distributed query
TypeConversionRule
from convert types other than timestamp and booleanMergeScan
MergeScan
MergeScan
is executed only in frontendThe error log:
Checklist
Refer to a related PR or issue link (optional)