-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove opentsdb tcp server #3828
refactor!: remove opentsdb tcp server #3828
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
==========================================
- Coverage 85.77% 85.29% -0.48%
==========================================
Files 952 952
Lines 162629 162931 +302
==========================================
- Hits 139492 138979 -513
- Misses 23137 23952 +815 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we have some docs to update after this PR merged? |
Yes, I'll check the doc once this pr is merged. |
I just saw this. Sorry. Let's move to draft to prevent unexpected merge. |
Now the |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This pr mainly removes the OpenTSDB TCP server, for
We have not yet reached a final agreement. Please leave comments below if you have opposite opinion.
Checklist