Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor refactor on etcd kvbackend #3940

Merged
merged 2 commits into from
May 14, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said:

  1. Avoid clone in txn
  2. Use KeyValue::from and remove convert_key_value method
  3. Use KeyValue::from instead of Into::into for clearer code

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 14, 2024
@fengjiachun fengjiachun requested a review from v0y4g3r as a code owner May 14, 2024 13:07
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (4ca7ac7) to head (919a56f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3940      +/-   ##
==========================================
- Coverage   85.65%   85.35%   -0.30%     
==========================================
  Files         967      967              
  Lines      165999   165989      -10     
==========================================
- Hits       142184   141685     -499     
- Misses      23815    24304     +489     

@WenyXu WenyXu added this pull request to the merge queue May 14, 2024
Merged via the queue into GreptimeTeam:main with commit 72897a2 May 14, 2024
21 checks passed
@fengjiachun fengjiachun deleted the feat/minor-refactor-etcd-client branch May 15, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants