-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds RegionScanner
trait
#3948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/region-scanner
branch
from
May 18, 2024 09:44
04a15c2
to
62d0119
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3948 +/- ##
==========================================
- Coverage 85.40% 85.18% -0.22%
==========================================
Files 978 977 -1
Lines 169100 169323 +223
==========================================
- Hits 144427 144245 -182
- Misses 24673 25078 +405 |
waynexia
reviewed
May 20, 2024
waynexia
reviewed
May 20, 2024
v0y4g3r
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
waynexia
approved these changes
May 20, 2024
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
May 21, 2024
* feat: define region scanner * feat: single partition scanner * feat: use single partition scanner * feat: implement ExecutionPlan wip * feat: mito engine returns single partition scanner * feat: implement DisplayAs for region server * feat: dummy table provider use handle_partitioned_query() * test: update sqlness test * feat: table provider use ReadFromRegion * refactor: remove StreamScanAdapter * chore: update lock * style: fix clippy * refactor: remove handle_query from the RegionEngine trait * chore: address CR comments * refactor: rename methods * refactor: rename ReadFromRegion to RegionScanExec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR adds the
RegionScanner
trait mentioned in #3886It allows us to split rows to scan into multiple partitions and increase scan parallelism. The
RegionEngine
has a new methodhandle_partitioned_query()
to get theRegionScanner
. It removes the oldhandle_query()
method from the trait and only exposes it in theMitoEngine
.Since most region engines don't support partitioning, this PR adds a
SinglePartitionScanner
to turn a stream into a region scanner.The execution plan returned by the dummy table provider now becomes the
ReadFromRegion
plan. This plan adapts aRegionScanner
to theExecutionPlan
trait.Checklist