-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SASL and TLS config for Kafka client #4536
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
==========================================
- Coverage 84.99% 84.70% -0.29%
==========================================
Files 1085 1085
Lines 194016 194167 +151
==========================================
- Hits 164899 164467 -432
- Misses 29117 29700 +583 |
SCRAM-SHA-512 requires dequbed/rsasl#48, influxdata/rskafka#247 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes look good to me. Should we need some unit tests to make the auth work ok?
8dcf7f3
to
054902c
Compare
Added in 735e6b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
Co-authored-by: Lei, HUANG <[email protected]>
* feat: add SASL and TLS config * feat: add SASL/PLAIN and TLS config for Kafka client * chore: use `ring` * feat: support SASL SCRAM-SHA-256 and SCRAM-SHA-512 * fix: correct unit test * test: add integration test * chore: apply suggestions from CR * refactor: introduce `KafkaConnectionConfig` * chore: refine toml examples * docs: add missing fields * chore: refine examples * feat: allow no server ca cert * chore: refine examples * chore: fix clippy * feat: load system ca certs * chore: fmt toml * chore: unpin version * Update src/common/wal/src/error.rs Co-authored-by: Lei, HUANG <[email protected]> --------- Co-authored-by: Lei, HUANG <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #4534
What's changed and what's your intention?
Allow users to configure the SASL/PLAIN, SASL/SCRAM-SHA-256, SASL/SCRAM-SHA-512 and TLS for the Kafka client
Checklist