Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal issue #57

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add modal issue #57

wants to merge 9 commits into from

Conversation

praffi-systemx
Copy link
Collaborator

  • add function to stop computation if any alarm is raised
  • add modal triggered when any alarm is raised
  • fix logger level and add --logging_level to app arguments
  • add --test_alarms as temporary test mode to force all alarms to trigger at any step

- add function to stop computation if any alarm is raised
- add modal triggered when any alarm is raised
- fix logger level and add --logging_level to app arguments
@BDonnot
Copy link
Collaborator

BDonnot commented Jul 8, 2022

Let me know when you'll "freeze" the feature on this pull request so that I can have a look

Thanks

@praffi-systemx
Copy link
Collaborator Author

You can have a look, I'm freezing this pull request and creating a new branch from dev_cab for improvement and other features.

@BDonnot
Copy link
Collaborator

BDonnot commented Jul 12, 2022

I did not look at the code yet, but from a user perspective:

  • it would be nice to differentiate between the "legacy" grid2game mode and the one developed by CAB project, maybe with a different command line argument ? Or another option in the command line argument ? I think it could be done without too much trouble and it would be easier to differentiate between the different usecase of the application.
  • the tab, when there is an issue, is "locked" we cannot do anything with it yet. I'm not sure it is ready to be merged on main yet
  • the "overload" column of this tab should also write the id (or better the name) of the line on overflow no ? (maybe see with Alexandre or Antoine)
  • to help debugging, I think it would be better to write the interaction in the logger at least so we see that the "clicks" on the button are properly recorded. For now i'm not sure if it's a "backend" issue (ie the clicks are properly recorded by nothing happens) or if it's a "front" issue (clicks are not detected correctly) or if it's something in between (eg no callbacks)

I'll look at the code asap to give more technical feedback if needed

@praffi-systemx
Copy link
Collaborator Author

Thank you for the review

  • I will add a legacy mode to the new mode selection dropdown (which is being implemented).
  • It has already be planned with CAB and RTE to have the line and/or the region of the overloads, but it isn't a priority.
  • The buttons in the recommendations table aren't implemented in this pull request.
  • I will add some logs on the python DEBUG level to help debugging

@praffi-systemx praffi-systemx marked this pull request as draft July 12, 2022 13:50
- only layout, no callbacks yet
- Simulate and integrate manual action buttons will show only if the recommendations are open.
- Simulate button doesn't work. There is a bug on main branch, simulated figure doesn't update on manual action.
- Refactoring of recommendations
- TODO: Handle multi-recommendations for human integrated actions
- add expert assist tab with basic view from grid2viz/src/simulation/ExpertAssist.py
  this tab interacts with the recommendations
- add some user input persistence through tab switch
- prevent initial call on most of CAB's callbacks to fix bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants