-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modal issue #57
Draft
praffi-systemx
wants to merge
9
commits into
main
Choose a base branch
from
dev_cab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add modal issue #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
praffi-systemx
commented
Jul 7, 2022
- add function to stop computation if any alarm is raised
- add modal triggered when any alarm is raised
- fix logger level and add --logging_level to app arguments
- add --test_alarms as temporary test mode to force all alarms to trigger at any step
- add function to stop computation if any alarm is raised - add modal triggered when any alarm is raised - fix logger level and add --logging_level to app arguments
Let me know when you'll "freeze" the feature on this pull request so that I can have a look Thanks |
You can have a look, I'm freezing this pull request and creating a new branch from dev_cab for improvement and other features. |
I did not look at the code yet, but from a user perspective:
I'll look at the code asap to give more technical feedback if needed |
Thank you for the review
|
- only layout, no callbacks yet
- Simulate and integrate manual action buttons will show only if the recommendations are open. - Simulate button doesn't work. There is a bug on main branch, simulated figure doesn't update on manual action. - Refactoring of recommendations - TODO: Handle multi-recommendations for human integrated actions
- add expert assist tab with basic view from grid2viz/src/simulation/ExpertAssist.py this tab interacts with the recommendations - add some user input persistence through tab switch - prevent initial call on most of CAB's callbacks to fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.