fix[next]: Allow np.bool scalar in gtfn backend #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +35,8 @@ def convert_arg(arg: Any) -> Any: | |||
| arr = arg.ndarray | |||
| origin = getattr(arg, "__gt_origin__", tuple([0] * len(arg.domain))) | |||
| return arr, origin | |||
| if isinstance(arg, np.bool_): | |||
There was a problem hiding this comment.
Suggested change
| if isinstance(arg, np.bool_): | |
| if isinstance(arg, np.bool_): |
Could you leave a comment why this is needed? Does numpy.float64 and python float work? If so, why does bool not work?
There was a problem hiding this comment.
I agree about adding a comment here and would also suggest to use a ternary operator:
return bool(arg) if isinstance(arg, np.bool_) else argThere was a problem hiding this comment.
This is a switch-like if therefore I wouldn't do the ternary, like in the other cases.
havogt
commented
Feb 28, 2025
| @@ -34,6 +35,9 @@ def convert_arg(arg: Any) -> Any: | |||
| arr = arg.ndarray | |||
| origin = getattr(arg, "__gt_origin__", tuple([0] * len(arg.domain))) | |||
| return arr, origin | |||
| if isinstance(arg, np.bool_): | |||
| # nanobind does not support implicit conversion of `np.bool` to `bool`# nanobind does not support implicit conversion of `np.bool` to `bool` | |||
There was a problem hiding this comment.
Suggested change
| # nanobind does not support implicit conversion of `np.bool` to `bool`# nanobind does not support implicit conversion of `np.bool` to `bool` | |
| # nanobind does not support implicit conversion of `np.bool` to `bool` |
tehrengruber
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1861.
Additional changes:
all-nextuv extra (to install dace-next)