Skip to content

Commit

Permalink
Remove artifact comment stuff (at least for now).
Browse files Browse the repository at this point in the history
Doesn't seem that necessary, and keeps causing problems unfortunately.
  • Loading branch information
blockninja124 committed Jan 14, 2025
1 parent 2b06d1f commit a38342e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 114 deletions.
104 changes: 0 additions & 104 deletions .github/workflows/pr-comment-artifacts.yml

This file was deleted.

4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ apply plugin: "org.jetbrains.kotlin.jvm"
//group = mod_version

base {
archivesName = "Starlance-${mod_version}${mod_artifact_suffix}"
archivesName = "${archives_base_name}-${mod_version}"
}

java {
Expand Down Expand Up @@ -275,7 +275,7 @@ tasks.named('jar', Jar).configure {
"Specification-Vendor": mod_authors,
"Specification-Version": "1", // We are version 1 of ourselves
"Implementation-Title": project.name,
"Implementation-Version": project.jar.archiveVersion,
"Implementation-Version": mod_version,
"Implementation-Vendor": mod_authors,
"Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ")
])
Expand Down
7 changes: 2 additions & 5 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
org.gradle.jvmargs=-Xmx6G
org.gradle.daemon=false

archives_base_name=vsch-1201
archives_base_name=starlance

# The mod version. See https://semver.org/
mod_version=1.2.0
Expand All @@ -20,8 +20,6 @@ mapping_version=1.20.1
mod_id=vsch
mod_name=Starlance: Valkyrien Skies X Cosmic Horizons
mod_license=All Rights Reserved
# keep artifact suffix empty cause its should be passed in command line
mod_artifact_suffix=
mod_group_id=net.jcm
mod_authors=Jcm, Brickyboy
mod_description=Adds Valkyrien Skies compat to Cosmic Horizons, as well as space-focused blocks for VS ships. [WIP]
Expand All @@ -42,5 +40,4 @@ flywheel_version = 0.6.11-13
registrate_version = MC1.20-1.3.3

lodestone_version=1.4.1.435
jei_version = 15.2.0.27
block_external_repositories=
jei_version = 15.2.0.27
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ default void clientTick(Level level, BlockPos pos, BlockState state, ParticleBlo
}

default void serverTick(Level level, BlockPos pos, BlockState state, ParticleBlockEntity be) {
if (level instanceof ServerLevel) {
tickForce(level, pos, state);
if (level instanceof ServerLevel serverLevel) {
tickForce(serverLevel, pos, state);
}
}

void tickForce(Level level, BlockPos pos, BlockState state);
void tickForce(ServerLevel level, BlockPos pos, BlockState state);

void tickParticles(Level level, BlockPos pos, BlockState state);
}

0 comments on commit a38342e

Please sign in to comment.